Fix for Issue 187: Stop screwing up classpath via ASM inclusion #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! I just used jarjar on one of my own projects to try it out, and was planning to do this sometime this week. Thanks for the patch and the research. I also talked to the JarJarLinks guys and they've given me permission to upload 1.1 to maven central, that should help. |
Open
lianhaijun
pushed a commit
to lianhaijun/lombok
that referenced
this pull request
May 8, 2020
Simple version check
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses jarjar to rename ASM without any Java source code changes in Lombok.
I don't have any large Lombok-enabled projects that I could use for testing, but at least in simple test projects everything works fine after this change.